Skip to content

[Saliency] Enable Java/Android bindings by adding 'WRAP java' to CMake #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

[Saliency] Enable Java/Android bindings by adding 'WRAP java' to CMake #4018

wants to merge 2 commits into from

Conversation

Akhil-Chaturvedi
Copy link

@Akhil-Chaturvedi Akhil-Chaturvedi commented Oct 3, 2025 •
edited
Loading

Fixes #4016

This addresses the inability to use the saliency module in Android (Java/Kotlin) applications. When generated using build_sdk.py, the native library compiles, but the Java wrapper class (org.opencv.saliency.Saliency) is not generated.

Technical Fix:

The ocv_define_module macro in modules/saliency/CMakeLists.txt was missing the java flag in its WRAP parameter.

Change in modules/saliency/CMakeLists.txt:

OLD
ocv_define_module(saliency opencv_imgproc opencv_features2d WRAP python)

NEW
ocv_define_module(saliency opencv_imgproc opencv_features2d WRAP python java)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Akhil-Chaturvedi
[Saliency] Enable Java/Android bindings by adding 'WRAP java' to CMake
e8ff9ec 
Fixes opencv#4016

This addresses the inability to use the `saliency` module in Android (Java/Kotlin) applications.
When generated using `build_sdk.py`, the native library compiles, but the Java wrapper class (`org.opencv.saliency.Saliency`) is not generated.

**Technical Fix:** 
The `ocv_define_module` macro in `modules/saliency/CMakeLists.txt` was missing the `java` flag in its `WRAP` parameter.

**Change in `modules/saliency/CMakeLists.txt`:**

# OLD
ocv_define_module(saliency opencv_imgproc opencv_features2d WRAP python)

# NEW
ocv_define_module(saliency opencv_imgproc opencv_features2d WRAP python java)
@Akhil-Chaturvedi Akhil-Chaturvedi mentioned this pull request Oct 3, 2025
Open
@asmorkalov asmorkalov self-requested a review October 6, 2025 08:31
@asmorkalov asmorkalov self-assigned this Oct 6, 2025
@asmorkalov
Copy link
Contributor

@Akhil-Chaturvedi Please handle CI warnings.

@asmorkalov
Copy link
Contributor 

  Warning: /home/ubuntu/opencv/modules/core/include/opencv2/core.hpp:3211:26: warning: 'virtual void cv::Algorithm::write(cv::FileStorage&) const' was hidden [-Woverloaded-virtual=]
  Warning: /home/ubuntu/opencv/modules/core/include/opencv2/core.hpp:3224:26: warning: 'virtual void cv::Algorithm::read(const cv::FileNode&)' was hidden [-Woverloaded-virtual=]

@Akhil-Chaturvedi
Updated saliencySpecializedClasses.hpp
ac111b6 
saliency: Fix -Woverloaded-virtual in header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees

@asmorkalov asmorkalov

Labels
category: saliency java bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to include saliency module in custom OpenCV build (core,imgproc,objdetect)
2 participants
@Akhil-Chaturvedi @asmorkalov